Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix CLUSTERS_KEEPER_TASK_INTERVAL env var #6812

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 22, 2024

What do these changes do?

Fix the CLUSTERS_KEEPER_TASK_INTERVAL validation (not anymore necessary).

Q: Why didn't we catch it locally?
A: The ops-configs were updated, but not the .env-devel file.

pydantic_core._pydantic_core.ValidationError: 1 validation error for ApplicationSettings

CLUSTERS_KEEPER_TASK_INTERVAL

  Value error, invalid literal for int() with base 10: '00:00:30' [type=value_error, input_value='00:00:30', input_type=str]

    For further information visit https://errors.pydantic.dev/2.9/v/value_error

Related issue/s

How to test

Dev-ops checklist

MR-1003

@giancarloromeo giancarloromeo self-assigned this Nov 22, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 22, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review November 22, 2024 13:26
@giancarloromeo giancarloromeo enabled auto-merge (squash) November 22, 2024 13:26
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

.env-devel Show resolved Hide resolved
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me thanks a lot

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.63%. Comparing base (5c8b32a) to head (2ef35df).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5c8b32a) and HEAD (2ef35df). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (5c8b32a) HEAD (2ef35df)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6812       +/-   ##
===========================================
- Coverage   88.40%   65.63%   -22.78%     
===========================================
  Files        1545      640      -905     
  Lines       61627    31643    -29984     
  Branches     2157      318     -1839     
===========================================
- Hits        54484    20770    -33714     
- Misses       6814    10813     +3999     
+ Partials      329       60      -269     
Flag Coverage Δ
integrationtests 64.76% <ø> (ø)
unittests 77.15% <100.00%> (-9.87%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper 98.73% <100.00%> (ø)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.67% <ø> (-14.36%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.53% <ø> (-29.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8b32a...2ef35df. Read the comment docs.

---- 🚨 Try these New Features:

@giancarloromeo giancarloromeo enabled auto-merge (squash) November 22, 2024 14:04
@giancarloromeo giancarloromeo merged commit ca228c3 into ITISFoundation:master Nov 22, 2024
82 of 89 checks passed
@giancarloromeo giancarloromeo deleted the fix-cluster-keeper-task-interval-env-var branch November 25, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants