-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Update PROJECTS_INACTIVITY_INTERVAL
env var format
#6797
♻️ Update PROJECTS_INACTIVITY_INTERVAL
env var format
#6797
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6797 +/- ##
==========================================
+ Coverage 88.35% 88.61% +0.26%
==========================================
Files 1538 619 -919
Lines 61475 30920 -30555
Branches 2166 318 -1848
==========================================
- Hits 54315 27400 -26915
+ Misses 6829 3460 -3369
+ Partials 331 60 -271
Continue to review full report in Codecov by Sentry.
|
PROJECTS_INACTIVITY_INTERVAL
env var format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. Careful with the osparc-config MR!!! This is a breaking change so you need to create different branches for those deploys where these variables cannot be applied right away until this code is released there
Please, read the MR's description.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot!
Quality Gate passedIssues Measures |
What do these changes do?
Adapt the
PROJECTS_INACTIVITY_INTERVAL
env var to be used with an interval inISO 8601
format.In Pydantic v1 numbers were considered seconds by default, but in Pydantic v2 they generate a
WARNING
.Related issue/s
How to test
Dev-ops checklist