🎨 [e2e]: Increase S4L's timeout when there is a workspace to download #6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
changed the title
odeimaiz
requested review from
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
matusdrobuliak66
approved these changes
Sep 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6338 +/- ##
=========================================
+ Coverage 84.5% 88.2% +3.6%
=========================================
Files 10 1499 +1489
Lines 214 62049 +61835
Branches 25 2065 +2040
=========================================
+ Hits 181 54776 +54595
- Misses 23 6957 +6934
- Partials 10 316 +306
Flags with carried forward coverage won't be shown. Click here to find out more. |
sanderegg
approved these changes
Sep 10, 2024
|
pcrespov
approved these changes
Sep 10, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The WPT e2e test is failing almost all the timeout because it can't start in the current 60".
This project also needs to download the 2.5GB from its workspace, so this PR relaxes this timeout to 60"+60".
Related issue/s
How to test
Dev-ops checklist