Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ Increases timeout of rpc calls #6326

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 9, 2024

What do these changes do?

Increases timeout of some critical rpc calls until finding out what is slowing down these calls (feedback @mguidon)

Related issue/s

How to test

In place

Dev-ops checklist

None

@pcrespov pcrespov self-assigned this Sep 9, 2024
@pcrespov pcrespov added this to the Eisbock milestone Sep 9, 2024
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Sep 9, 2024
@pcrespov pcrespov enabled auto-merge (squash) September 9, 2024 07:47
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.9%. Comparing base (cafbf96) to head (1dae35e).
Report is 515 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6326      +/-   ##
=========================================
+ Coverage    84.5%   87.9%    +3.3%     
=========================================
  Files          10    1164    +1154     
  Lines         214   51192   +50978     
  Branches       25     925     +900     
=========================================
+ Hits          181   45014   +44833     
- Misses         23    6007    +5984     
- Partials       10     171     +161     
Flag Coverage Δ
integrationtests 64.6% <100.0%> (?)
unittests 85.5% <100.0%> (+0.9%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ervice-library/src/servicelib/rabbitmq/__init__.py 100.0% <100.0%> (ø)
...icelib/rabbitmq/rpc_interfaces/catalog/services.py 0.0% <ø> (ø)
...ver/src/simcore_service_webserver/payments/_rpc.py 50.7% <100.0%> (ø)

... and 1171 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want a ENV variable at some point

Copy link

sonarqubecloud bot commented Sep 9, 2024

@pcrespov pcrespov merged commit 6d6f5c5 into ITISFoundation:master Sep 9, 2024
57 checks passed
@pcrespov pcrespov deleted the mai/timeout-n-optional-hc branch November 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants