Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Folders & Workspaces: Missing features I #6317

Merged
merged 38 commits into from
Sep 10, 2024
Merged

🎨 [Frontend] Folders & Workspaces: Missing features I #6317

merged 38 commits into from
Sep 10, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 6, 2024 •
edited
Loading

What do these changes do?

  • Improve Folders Tree
  • Improve Workspaces Tree
  • Show MoveToWorkspace Warning message
  • Shared icon on folder if Shared Workspace
  • Workspace header: provide edit and share

Improvements

Related issue/s

@odeimaiz odeimaiz self-assigned this Sep 6, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 6, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Sep 6, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) September 9, 2024 13:58
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Missing features I 🎨 [Frontend] Folder & Workspaces: Missing features I Sep 9, 2024
@odeimaiz odeimaiz disabled auto-merge September 9, 2024 14:00
@odeimaiz odeimaiz enabled auto-merge (squash) September 9, 2024 14:00
matusdrobuliak66
matusdrobuliak66 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wunderbar

pcrespov
pcrespov reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@odeimaiz odeimaiz changed the title 🎨 [Frontend] Folder & Workspaces: Missing features I 🎨 [Frontend] Folders & Workspaces: Missing features I Sep 9, 2024
GitHK
GitHK reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jsaq007
jsaq007 reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found this issue when moving a folder to a workspace.

2024-09-10 13 59 54

@matusdrobuliak66
Copy link
Contributor

matusdrobuliak66 commented Sep 10, 2024 •
edited
Loading

Just found this issue when moving a folder to a workspace.

2024-09-10 13 59 54

Good catch! this functionality is not yet supported by the backend. I need to catch up there ;) But its not a blocker to release, worst-case scenario we hotfix and disable this button.

@odeimaiz odeimaiz requested a review from jsaq007 September 10, 2024 12:08
@odeimaiz odeimaiz merged commit a3b8340 into ITISFoundation:master Sep 10, 2024
55 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Sep 10, 2024
@odeimaiz @mrnicegyu11
🎨 [Frontend] Folder & Workspaces: Missing features I (ITISFoundation#…
b519cbb 
…6317)
This was referenced Sep 11, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

@sanderegg sanderegg Awaiting requested review from sanderegg

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Eisbock
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @matusdrobuliak66 @jsaq007 @GitHK @pcrespov