Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Frontend] Workspaces: Connect to backend #6304

Merged
merged 70 commits into from
Sep 6, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 4, 2024

What do these changes do?

  • CRUD on Workspaces
  • CRUD on Workspaces/groups
  • Add workspaceId to project listing
  • Add folderId and workspaceId to project creation
  • Remove description from folders
  • Add workspaceId to folder listing
  • Disable Sharing in Shared Workspace (access rights are set at workspace level)
  • Move Project to Workspace
  • Move Folder to Folder
  • Move Folder to Workspace

Bonus

  • Improve Sharing UX for new users
    • If a user doesn't see a single collaborator, it means that they are still not part of an organization. Point them to the Organizations.
    • Do not enable the Share button if a collaborator is not selected. Users might have entered an email address in the filter and think it should work.
    • Show email address in parenthesis
  • Improve Quick Start logic

CRUDS
WorkspacesCrud

Bonus: Tell me about Organizations
CreateOrgs

Bonus: Show email address and enable/disable button
EmailsAndDisabled

Related issue/s

related to ITISFoundation/osparc-issues#716
related to ITISFoundation/osparc-issues#1606

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Sep 4, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Sep 4, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 4, 2024
@odeimaiz odeimaiz requested a review from ignapas as a code owner September 5, 2024 14:01
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@odeimaiz odeimaiz enabled auto-merge (squash) September 5, 2024 15:32
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarqubecloud bot commented Sep 6, 2024

@sanderegg sanderegg disabled auto-merge September 6, 2024 09:16
@sanderegg sanderegg merged commit 4d70330 into ITISFoundation:master Sep 6, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants