-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ web-api interface for tags sharing and add to services #6298
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6298 +/- ##
=========================================
- Coverage 84.5% 82.3% -2.2%
=========================================
Files 10 591 +581
Lines 214 30176 +29962
Branches 25 260 +235
=========================================
+ Hits 181 24861 +24680
- Misses 23 5255 +5232
- Partials 10 60 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6e56505
to
b53f1ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! As discussed, for future consideration (and also for future resources): since a tag is a resource that is bound either to a service or a project, I believe we do not need to have a tag-sharing functionality. Additionally, we do not need to bother the user with sharing tags.
A valid approach might be to resolve permissions in the service layer of the tag as the first step. If it's a project tag, check whether the user has write permissions for the project. If it's a service tag, check whether the user has write permissions for the service. If the user does not have the necessary permissions, we do not allow to proceed further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks.
services/web/server/src/simcore_service_webserver/projects/_tags_handlers.py
Outdated
Show resolved
Hide resolved
7f4d6e0
to
3b744f3
Compare
Quality Gate passedIssues Measures |
What do these changes do?
Creates the web-api (w/o implementation) to both share tags and assign tags to services.
group
) and sub-resource associations (e.g.tags
inservices
orprojects
)web-api
tags
with othergroups
tags
to (existing)projects
and now also to (existing) catalog'sservices
. Note that this adds or removes a relation/association since neither of the resources are created or deleted here.Related issue/s
How to test
Dev-ops checklist