Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Backend part of UX improvements #6297

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 3, 2024

What do these changes do?

Removes the "changing" part of the message going to the frontend, so that @odeimaiz can change how copying is shown.

Maybe when time is right we shall better go with #6288 but for now this appears to critical to apply it.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Sep 3, 2024
@sanderegg sanderegg added this to the Eisbock milestone Sep 3, 2024
@sanderegg sanderegg self-assigned this Sep 3, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.2%. Comparing base (cafbf96) to head (46e7706).
Report is 499 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6297      +/-   ##
=========================================
- Coverage    84.5%   66.2%   -18.4%     
=========================================
  Files          10     614     +604     
  Lines         214   31238   +31024     
  Branches       25     260     +235     
=========================================
+ Hits          181   20699   +20518     
- Misses         23   10479   +10456     
- Partials       10      60      +50     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 89.4% <ø> (+4.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/storage/src/simcore_service_storage/s3_utils.py 74.2% <ø> (ø)

... and 623 files with indirect coverage changes

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

services/storage/src/simcore_service_storage/s3_utils.py Outdated Show resolved Hide resolved
@sanderegg sanderegg force-pushed the duplicating-simple-change branch from 1fd5739 to 46e7706 Compare September 3, 2024 21:38
@sanderegg sanderegg enabled auto-merge (squash) September 3, 2024 21:39
Copy link

sonarqubecloud bot commented Sep 3, 2024

@sanderegg sanderegg merged commit dc0d182 into ITISFoundation:master Sep 3, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants