Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Flaky tests improvements #6292

Merged
merged 13 commits into from
Sep 4, 2024
Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Sep 3, 2024

What do these changes do?

  • fixed broken detach feature and broken test_attach_detach_container_to_network
  • avoids duplicated email when creating multiple users via random_user
  • tentative fix flaky test_lock_acquired_in_parallel_to_update_same_resource
  • fixed bug with InvitationGenerated treating issuer as LowerCaseEmailStr instead of a str; API inputs parser InvitationInputs already trims down the issuer and treats it as str

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Sep 3, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Sep 3, 2024
@GitHK GitHK added this to the Eisbock milestone Sep 3, 2024
@GitHK GitHK changed the title 🐛 Flaky tests fixes 🐛 Flaky tests improvements Sep 3, 2024
@GitHK GitHK marked this pull request as ready for review September 3, 2024 08:49
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (6d2891c).
Report is 500 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6292      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1477    +1467     
  Lines         214   61114   +60900     
  Branches       25    2063    +2038     
=========================================
+ Hits          181   53870   +53689     
- Misses         23    6929    +6906     
- Partials       10     315     +305     
Flag Coverage Δ
integrationtests 64.8% <0.0%> (?)
unittests 86.1% <100.0%> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/models_library/api_schemas_webserver/product.py 100.0% <100.0%> (ø)
...s/models-library/src/models_library/invitations.py 76.9% <100.0%> (ø)
...ervice_dynamic_sidecar/api/containers_extension.py 94.5% <100.0%> (ø)
...ervice_webserver/products/_invitations_handlers.py 100.0% <ø> (ø)

... and 1423 files with indirect coverage changes

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. please check these comments

@GitHK GitHK requested a review from pcrespov September 3, 2024 11:31
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link

sonarqubecloud bot commented Sep 4, 2024

@GitHK GitHK merged commit 161599b into ITISFoundation:master Sep 4, 2024
57 checks passed
@GitHK GitHK deleted the pr-osparc-flaky-tests branch September 4, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky tests/test_redis.py::test_lock_acquired_in_parallel_to_update_same_resource
3 participants