-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Flaky tests improvements #6292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6292 +/- ##
=========================================
+ Coverage 84.5% 88.1% +3.5%
=========================================
Files 10 1477 +1467
Lines 214 61114 +60900
Branches 25 2063 +2038
=========================================
+ Hits 181 53870 +53689
- Misses 23 6929 +6906
- Partials 10 315 +305
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. please check these comments
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/containers_extension.py
Outdated
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_webserver/product.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
packages/models-library/src/models_library/api_schemas_webserver/product.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/products/_invitations_handlers.py
Show resolved
Hide resolved
…re-forked into pr-osparc-flaky-tests
Quality Gate passedIssues Measures |
What do these changes do?
test_attach_detach_container_to_network
random_user
test_lock_acquired_in_parallel_to_update_same_resource
InvitationGenerated
treating issuer asLowerCaseEmailStr
instead of astr
; API inputs parserInvitationInputs
already trims down the issuer and treats it asstr
Related issue/s
How to test
Dev-ops checklist