Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Workspaces / Folders v2 🗃️🚨 #6248

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Aug 27, 2024

What do these changes do?

  • ✨ introduce workspaces concept ~ shared folder (its matter of representation -> its complex topic, I am happy to discuss/explain in person all my decisions)
  • ♻️ recreated folders logic -> folders_v2 (for now I want to keep even old one, but it is not used)
  • ♻️ refactor Project permissions (move all permissions check from DB layer -> Service layer "api")
    • Now project permission is resolved in this function: get_user_project_access_rights

  • @odeimaiz you can start to adjust based on this PR
    • Moving between workspaces is not yet implemented.

Related issue/s

How to test

  • test_folders.py
  • test_workspaces.py
  • test_workspaces_groups.py
  • test_workspaces__folders_and_projects_crud.py

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 93.44262% with 56 lines in your changes missing coverage. Please review.

Project coverage is 86.2%. Comparing base (cafbf96) to head (5126448).
Report is 501 commits behind head on master.

Files with missing lines Patch % Lines
...imcore_service_webserver/workspaces/_groups_api.py 80.0% 11 Missing ⚠️
.../simcore_service_webserver/folders/_folders_api.py 78.7% 10 Missing ⚠️
...simcore_service_webserver/workspaces/_groups_db.py 84.0% 8 Missing ⚠️
...rvice_webserver/workspaces/_workspaces_handlers.py 92.0% 8 Missing ⚠️
...ore_service_webserver/projects/_projects_access.py 20.0% 4 Missing ⚠️
...simcore_service_webserver/projects/projects_api.py 78.9% 4 Missing ⚠️
...c/simcore_service_webserver/folders/_folders_db.py 95.8% 3 Missing ⚠️
...ore_service_webserver/projects/_crud_api_create.py 70.0% 3 Missing ⚠️
...simcore_service_webserver/projects/_folders_api.py 90.9% 2 Missing ⚠️
...ore_service_webserver/workspaces/_workspaces_db.py 96.7% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6248      +/-   ##
=========================================
+ Coverage    84.5%   86.2%    +1.6%     
=========================================
  Files          10    1495    +1485     
  Lines         214   61722   +61508     
  Branches       25    2063    +2038     
=========================================
+ Hits          181   53229   +53048     
- Misses         23    8193    +8170     
- Partials       10     300     +290     
Flag Coverage Δ
unittests 86.2% <93.4%> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...models-library/src/models_library/access_rights.py 100.0% <100.0%> (ø)
...models_library/api_schemas_webserver/folders_v2.py 100.0% <100.0%> (ø)
...c/models_library/api_schemas_webserver/projects.py 100.0% <100.0%> (ø)
...models_library/api_schemas_webserver/workspaces.py 100.0% <100.0%> (ø)
...kages/models-library/src/models_library/folders.py 100.0% <100.0%> (ø)
...ages/models-library/src/models_library/projects.py 92.5% <100.0%> (ø)
...es/models-library/src/models_library/workspaces.py 100.0% <100.0%> (ø)
...src/simcore_postgres_database/models/folders_v2.py 100.0% <100.0%> (ø)
...e/src/simcore_postgres_database/models/projects.py 100.0% <ø> (ø)
...re_postgres_database/models/projects_to_folders.py 100.0% <100.0%> (ø)
... and 43 more

... and 1396 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: Sharing folders ✨ Workspaces / Folders v2 / Sharing folders Aug 30, 2024
@matusdrobuliak66 matusdrobuliak66 changed the title ✨ Workspaces / Folders v2 / Sharing folders ✨ Workspaces / Folders v2 / Sharing folders 🗃️🚨 Aug 30, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review August 30, 2024 05:57
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair reviewed. thx

@odeimaiz odeimaiz mentioned this pull request Sep 3, 2024
6 tasks
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 4, 2024 07:27
Copy link

sonarqubecloud bot commented Sep 4, 2024

@matusdrobuliak66 matusdrobuliak66 merged commit 66d69a6 into ITISFoundation:master Sep 4, 2024
56 of 57 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the sharing-folders branch September 4, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web API: /folders/<folder-id>/groups/<group-id> CRUD operations
4 participants