Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Bugfix: Cannot instantiate templates #6198

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 16, 2024

What do these changes do?

This #5786 changed how the webserver calls into storage by replacing uuid_filter with project_id. This in effect created an issue with how much files were returned.
This was indirectly fixed by #5796, which introduced then another problem:
ITISFoundation/osparc-issues#1587

so now, there is again an in-between, which should fix most of the issues. but maybe have a slight reduce

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Aug 16, 2024
@sanderegg sanderegg added this to the Eisbock milestone Aug 16, 2024
@sanderegg sanderegg self-assigned this Aug 16, 2024
@sanderegg sanderegg requested a review from pcrespov as a code owner August 16, 2024 09:50
@sanderegg sanderegg requested review from odeimaiz and mguidon August 16, 2024 09:51
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.2%. Comparing base (cafbf96) to head (2b9fef5).
Report is 441 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6198      +/-   ##
=========================================
- Coverage    84.5%   80.2%    -4.4%     
=========================================
  Files          10    1002     +992     
  Lines         214   45336   +45122     
  Branches       25     234     +209     
=========================================
+ Hits          181   36378   +36197     
- Misses         23    8900    +8877     
- Partials       10      58      +48     
Flag Coverage Δ
integrationtests 59.6% <ø> (?)
unittests 77.9% <100.0%> (-6.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/simcore_service_catalog/services/services_api.py 77.7% <100.0%> (ø)
...rage/src/simcore_service_storage/handlers_files.py 99.2% <ø> (ø)

... and 1010 files with indirect coverage changes

@sanderegg sanderegg changed the title 🐛Bugfix: Cannot instanciate templates 🐛Bugfix: Cannot instantiate templates Aug 16, 2024
Copy link

@sanderegg sanderegg merged commit 6773ddc into ITISFoundation:master Aug 16, 2024
49 of 54 checks passed
@sanderegg sanderegg deleted the bugfix/storage branch August 16, 2024 11:14
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 21, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot instantiate study from TEMPLATE
3 participants