-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Bugfix: Cannot instantiate templates #6198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6198 +/- ##
=========================================
- Coverage 84.5% 80.2% -4.4%
=========================================
Files 10 1002 +992
Lines 214 45336 +45122
Branches 25 234 +209
=========================================
+ Hits 181 36378 +36197
- Misses 23 8900 +8877
- Partials 10 58 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Quality Gate passedIssues Measures |
What do these changes do?
This #5786 changed how the webserver calls into storage by replacing uuid_filter with project_id. This in effect created an issue with how much files were returned.
This was indirectly fixed by #5796, which introduced then another problem:
ITISFoundation/osparc-issues#1587
so now, there is again an in-between, which should fix most of the issues. but maybe have a slight reduce
fixes Cannot instantiate study from TEMPLATE osparc-issues#1593
Bonus:
Related issue/s
How to test
Dev-ops checklist