Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] 🎨 TIP enhancements #6197

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 16, 2024

What do these changes do?

  • Do not push TEMPLATE_SHARED notification if users are not supposed to see the templates
  • Don't show user's role if it's User

Do not push TEMPLATE_SHARED notification:
PushNotifications

Tester:
image

User:
image

Related issue/s

closes ITISFoundation/osparc-issues#1591
closes ITISFoundation/osparc-issues#1592

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 16, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Aug 16, 2024
@odeimaiz odeimaiz added this to the Eisbock milestone Aug 16, 2024
@odeimaiz odeimaiz marked this pull request as ready for review August 16, 2024 09:50
@odeimaiz odeimaiz enabled auto-merge (squash) August 16, 2024 09:58
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz requested a review from elisabettai August 16, 2024 12:22
Copy link

@odeimaiz odeimaiz merged commit 3c05604 into ITISFoundation:master Aug 19, 2024
51 checks passed
giancarloromeo pushed a commit to giancarloromeo/osparc-simcore that referenced this pull request Aug 19, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 21, 2024
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show user's role if it's User Template shared notifications in TIP
5 participants