Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes access rights fields in web-api's PATCH services input model #6180

Merged
merged 13 commits into from
Aug 13, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Aug 13, 2024

What do these changes do?

In the web-api, the input model for the Update service operation was using old names. Since inputs have ignore policy, the update of accessRights did not have effect.

  • Created new explicit model ServiceUpdateV2
  • Updates OAS

NOTE: follow up will do a full cleanup of old models and entrypoints. This was avoided in this PR to simplify reviewing.

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/with_dbs/01/test_catalog_handlers__services.py

Dev-ops checklist

@pcrespov pcrespov self-assigned this Aug 13, 2024
@pcrespov pcrespov added this to the Eisbock milestone Aug 13, 2024
@pcrespov pcrespov added a:webserver issue related to the webserver service a:catalog catalog service labels Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.0%. Comparing base (cafbf96) to head (12bdc73).
Report is 431 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6180      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.4%     
=========================================
  Files          10    1113    +1103     
  Lines         214   48967   +48753     
  Branches       25     589     +564     
=========================================
+ Hits          181   43109   +42928     
- Misses         23    5724    +5701     
- Partials       10     134     +124     
Flag Coverage Δ
integrationtests 64.8% <100.0%> (?)
unittests 88.1% <100.0%> (+3.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/models_library/api_schemas_catalog/services.py 100.0% <100.0%> (ø)
...rc/models_library/api_schemas_webserver/catalog.py 100.0% <100.0%> (ø)
...dels-library/src/models_library/services_access.py 100.0% <100.0%> (ø)
...g/src/simcore_service_catalog/api/rpc/_services.py 91.9% <ø> (ø)
...c/simcore_service_catalog/services/services_api.py 78.8% <100.0%> (ø)
...rver/src/simcore_service_webserver/catalog/_api.py 59.4% <100.0%> (ø)

... and 1098 files with indirect coverage changes

@pcrespov pcrespov force-pushed the is5964/fixes-access-rights branch from 5240c97 to eebb0d4 Compare August 13, 2024 13:31
@pcrespov pcrespov marked this pull request as ready for review August 13, 2024 13:36
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci

@pcrespov pcrespov changed the title 🐛 Is5964/fixes access rights 🐛 Fixes access rights fields in web-api's PATCH services input model Aug 13, 2024
@pcrespov pcrespov force-pushed the is5964/fixes-access-rights branch from d4e1fb6 to 12bdc73 Compare August 13, 2024 16:49
Copy link

@pcrespov pcrespov enabled auto-merge (squash) August 13, 2024 19:48
@pcrespov pcrespov merged commit 0cc540f into ITISFoundation:master Aug 13, 2024
57 checks passed
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov deleted the is5964/fixes-access-rights branch August 14, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:catalog catalog service a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants