-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes access rights fields in web-api's PATCH services input model #6180
🐛 Fixes access rights fields in web-api's PATCH services input model #6180
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6180 +/- ##
=========================================
+ Coverage 84.5% 88.0% +3.4%
=========================================
Files 10 1113 +1103
Lines 214 48967 +48753
Branches 25 589 +564
=========================================
+ Hits 181 43109 +42928
- Misses 23 5724 +5701
- Partials 10 134 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5240c97
to
eebb0d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
packages/models-library/src/models_library/api_schemas_catalog/services.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merci
d4e1fb6
to
12bdc73
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
In the web-api, the input model for the
Update
service operation was using old names. Since inputs haveignore
policy, the update ofaccessRights
did not have effect.ServiceUpdateV2
NOTE: follow up will do a full cleanup of old models and entrypoints. This was avoided in this PR to simplify reviewing.
Related issue/s
How to test
Dev-ops checklist