Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Maintenance: fixes warning in pytest #6172

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 12, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Aug 12, 2024
@sanderegg sanderegg added this to the Tom Bombadil milestone Aug 12, 2024
@sanderegg sanderegg self-assigned this Aug 12, 2024
@sanderegg sanderegg requested a review from pcrespov as a code owner August 12, 2024 13:32
@sanderegg sanderegg force-pushed the maintenance/fix-import-warning branch from e140194 to 6473900 Compare August 12, 2024 13:32
@sanderegg sanderegg enabled auto-merge (squash) August 12, 2024 13:32
Copy link

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo! 🎉

@sanderegg sanderegg disabled auto-merge August 12, 2024 13:54
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.0%. Comparing base (cafbf96) to head (6473900).
Report is 422 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6172      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.4%     
=========================================
  Files          10    1462    +1452     
  Lines         214   60662   +60448     
  Branches       25    1480    +1455     
=========================================
+ Hits          181   53427   +53246     
- Misses         23    6924    +6901     
- Partials       10     311     +301     
Flag Coverage Δ
integrationtests 64.4% <ø> (?)
unittests 86.0% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1418 files with indirect coverage changes

@sanderegg sanderegg merged commit 85cb773 into ITISFoundation:master Aug 12, 2024
57 checks passed
@sanderegg sanderegg deleted the maintenance/fix-import-warning branch August 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: pytest.register_assert_rewrite warning
2 participants