Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade traefik to major version 3 #6171

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Aug 12, 2024

What do these changes do?

  • Upgrades traefik to v3
  • For now uses traefik-v2 style routing (this needs to be changed eventually...)
  • Change: docker provider is now called swarm
  • Change: Already prepare OTLP tracing and remove old-style jaeger/zipkin connection

Related PRs

How to test

Dev-ops checklist

@mrnicegyu11 mrnicegyu11 changed the title bump traefik ⬆️ Upgrade traefik to major version 3 Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (f3ae779).
Report is 423 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6171      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1462    +1452     
  Lines         214   60662   +60448     
  Branches       25    1480    +1455     
=========================================
+ Hits          181   53464   +53283     
- Misses         23    6887    +6864     
- Partials       10     311     +301     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 86.0% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ules/dynamic_sidecar/docker_service_specs/proxy.py 100.0% <ø> (ø)
.../director/src/simcore_service_director/producer.py 66.2% <ø> (ø)

... and 1416 files with indirect coverage changes

@mrnicegyu11 mrnicegyu11 added this to the Tom Bombadil milestone Aug 12, 2024
@mrnicegyu11 mrnicegyu11 added the t:enhancement Improvement or request on an existing feature label Aug 12, 2024
@mrnicegyu11 mrnicegyu11 self-assigned this Aug 12, 2024
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review August 12, 2024 13:48
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

services/docker-compose.yml Show resolved Hide resolved
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good thanks!

@sanderegg sanderegg modified the milestones: Tom Bombadil, Eisbock Aug 13, 2024
@mrnicegyu11 mrnicegyu11 merged commit 204a2fa into ITISFoundation:master Aug 13, 2024
2 checks passed
Copy link

@mrnicegyu11 mrnicegyu11 deleted the 2024/change/traefikV3 branch August 13, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants