Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] Fix always visible Update available icon #6161

Merged
merged 4 commits into from
Aug 9, 2024
Merged

🐛 [Frontend] Fix always visible Update available icon #6161

merged 4 commits into from
Aug 9, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Aug 9, 2024 •
edited
Loading

What do these changes do?

The "Update available" icon was always visible, this PR fixes it.
UpdateAvailable

Before:
image

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Aug 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Aug 9, 2024
@odeimaiz odeimaiz added this to the Tom Bombadil milestone Aug 9, 2024
@odeimaiz odeimaiz marked this pull request as ready for review August 9, 2024 08:43
@odeimaiz odeimaiz enabled auto-merge (squash) August 9, 2024 08:43
@odeimaiz odeimaiz changed the title 🐛 [Frontend] Fix always visible update available icon 🐛 [Frontend] Fix always visible Update available icon Aug 9, 2024
sanderegg
sanderegg reviewed Aug 9, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

elisabettai
elisabettai approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 Good catch! (I didn't notice while playing on master yesterday).

@mrnicegyu11 mrnicegyu11 disabled auto-merge August 9, 2024 11:00
@mrnicegyu11 mrnicegyu11 merged commit b0c60f0 into ITISFoundation:master Aug 9, 2024
51 checks passed
This was referenced Aug 15, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@elisabettai elisabettai elisabettai approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov

@mguidon mguidon Awaiting requested review from mguidon

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @elisabettai @sanderegg @mrnicegyu11