Skip to content

Commit

Permalink
fixed test that started failing, but is correct
Browse files Browse the repository at this point in the history
  • Loading branch information
sanderegg committed Dec 9, 2024
1 parent 840f518 commit 5b89582
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ async def _assert_wait_for_ec2_instances_running() -> list[InstanceTypeDef]:
mock_find_node_with_name_returns_fake_node.assert_called_once()
mock_find_node_with_name_returns_fake_node.reset_mock()

assert mock_docker_tag_node.call_count == 2
assert mock_docker_tag_node.call_count == 3
assert fake_node.spec
assert fake_node.spec.labels
# check attach call
Expand Down Expand Up @@ -678,7 +678,8 @@ async def _assert_wait_for_ec2_instances_running() -> list[InstanceTypeDef]:
assert mock_compute_node_used_resources.call_count == num_useless_calls * 2
mock_compute_node_used_resources.reset_mock()
mock_find_node_with_name_returns_fake_node.assert_not_called()
mock_docker_tag_node.assert_not_called()
assert mock_docker_tag_node.call_count == num_useless_calls
mock_docker_tag_node.reset_mock()
mock_docker_set_node_availability.assert_not_called()
# check the number of instances did not change and is still running
instances = await assert_autoscaled_dynamic_ec2_instances(
Expand Down

0 comments on commit 5b89582

Please sign in to comment.