test fixes

ITISFoundation · Nov 13, 2024 · 22dba14 · 22dba14
1 parent 3a71a7a
commit 22dba14
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/services/director-v2/src/simcore_service_director_v2/modules/dynamic_services.py b/services/director-v2/src/simcore_service_director_v2/modules/dynamic_services.py
@@ -16,7 +16,7 @@
 logger = logging.getLogger(__name__)
 
 
-def setup(app: FastAPI, tracing_settings: TracingSettings) -> None:
+def setup(app: FastAPI, tracing_settings: TracingSettings | None) -> None:
     def on_startup() -> None:
         client = httpx.AsyncClient(
             timeout=app.state.settings.CLIENT_REQUEST.HTTP_CLIENT_REQUEST_TOTAL_TIMEOUT

diff --git a/services/director-v2/tests/integration/02/test_dynamic_sidecar_nodeports_integration.py b/services/director-v2/tests/integration/02/test_dynamic_sidecar_nodeports_integration.py
@@ -64,6 +64,7 @@
 from settings_library.rabbit import RabbitSettings
 from settings_library.redis import RedisSettings
 from settings_library.storage import StorageSettings
+from settings_library.tracing import TracingSettings
 from simcore_postgres_database.models.comp_pipeline import comp_pipeline
 from simcore_postgres_database.models.comp_tasks import comp_tasks
 from simcore_postgres_database.models.projects_networks import projects_networks
@@ -340,8 +341,14 @@ async def patch_storage_setup(
 
     original_setup = dv2_modules_storage.setup
 
-    def setup(app: FastAPI, settings: StorageSettings) -> None:
-        original_setup(app, storage_settings=local_settings, tracing_settings=None)
+    def setup(
+        app: FastAPI,
+        storage_settings: StorageSettings,
+        tracing_settings: TracingSettings | None,
+    ) -> None:
+        original_setup(
+            app, storage_settings=local_settings, tracing_settings=tracing_settings
+        )
 
     mocker.patch("simcore_service_director_v2.modules.storage.setup", side_effect=setup)