Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#82-student-bootcamp-detail-endppoint #93

Merged
merged 28 commits into from
Mar 6, 2024
Merged

Feature/#82-student-bootcamp-detail-endppoint #93

merged 28 commits into from
Mar 6, 2024

Conversation

AlejandroNPereyra
Copy link
Contributor

I made an endpoint to provide FE a fake data student bootcamp details array.

@AlejandroNPereyra AlejandroNPereyra linked an issue Feb 28, 2024 that may be closed by this pull request
[BE]Add a fake endpoint that can list 'Datos del bootcamp' for frontend student detail view #82
Closed
AlejandroNPereyra
AlejandroNPereyra commented Feb 28, 2024
View reviewed changes
Copy link
Contributor Author

@AlejandroNPereyra AlejandroNPereyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array content was disscused previously with FE

@AlejandroNPereyra AlejandroNPereyra self-assigned this Feb 28, 2024
AlejandroNPereyra
AlejandroNPereyra commented Mar 5, 2024
View reviewed changes
Copy link
Contributor Author

@AlejandroNPereyra AlejandroNPereyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He quitado los campos que sobraban, pertenecían a los de otra formación... gracias!

app/Http/Controllers/api/StudentBootcampDetailController.php Outdated Show resolved Hide resolved
app/Http/Controllers/api/StudentBootcampDetailController.php Outdated Show resolved Hide resolved
@jordimorillo jordimorillo force-pushed the feature/#82-student-bootcamp-detail-endppoint branch from 1800088 to a10e7d7 Compare March 5, 2024 19:15
coxen34
coxen34 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@coxen34 coxen34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@AlejandroNPereyra AlejandroNPereyra merged commit d850eb2 into develop Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordimorillo jordimorillo jordimorillo approved these changes

@coxen34 coxen34 coxen34 approved these changes

Assignees

@AlejandroNPereyra AlejandroNPereyra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE]Add a fake endpoint that can list 'Datos del bootcamp' for frontend student detail view
3 participants
@AlejandroNPereyra @jordimorillo @coxen34