Feature/fake-students-endpoint #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coxen34
requested review from
AlejandroNPereyra,
FranEnLaNube,
jordimorillo and
pupadevs
FranEnLaNube
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
As a feature to just test if we can connect our repo with our FE partners one, I think is fair enough. IDK if @jordimorillo would like to test this, but ATM I Think is ok.
Good and really fast job! 🎉
pupadevs
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Good work, I have tested the test route on local machine and everything is fine. 😸
- I have a suggestion to add to your contribution, instead of throwing the array of students directly in the routes, you can create a json file in the public folder and store the data in that file.
Example:
return response()->file(public_path('fakeData.json'));
I think it adds more elegibity and if you decide to add more fields or more students, the path file will be very loaded with data that will only be test data.
AlejandroNPereyra
approved these changes
Jan 31, 2024
|
Now the students.json file is located in database/data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fake route and images