[BE] Small details on LoginControllerTest and AdminController #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elpupas , these are some contributions to fix #39, maybe it fixes it.
Changes
I just made changes in these files, the rest has been PINT 🤷♂️
LoginControllerTest.php
use DatabaseTransactions
to avoid refresh data base on each testing or usinguse refreshDatabase
, which resets database in every testing, leaving it totally empty.$response = $this->json('POST', '/api/v1/login', $credentials);
to$response = $this->post(route('login'), $credentials);
to avoid SonarCloud messages given that there were string repetition.AdminController.php
$admin
of fromfindAdmin()