[FE] Refactor: #266 fe rename and reorganise files and folders structure #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: renamed: src/api/student/getResourceStudentWithId.ts -> src/api/student/getStudentDetailWithId.ts modified: src/store/thunks/getDetailResourceStudentWithIdThunk.ts
Changes to be committed: modified: src/store/thunks/getDetailResourceStudentWithIdThunk.ts
Changes to be committed: renamed: src/api/index.ts -> src/api/getResourceWithAxios.ts modified: src/api/student/getStudentDetailWithId.ts
…anize-files-and-folders 266-3 [FE] Refactor : Reorganize redux store folders and tests
The data returned by the call to /student/{studentId}/resume/projects has changed, before it received "project_name", now it is "name".
Changes to be committed:
modified: src/components/studentDetailCards/projectsSection/ProjectsCard.tsx
Changes not staged for commit:
modified: src/interfaces/interfaces.ts
The data returned by the call to /student/{studentId}/resume/projects has changed, before it received "project_name", now it is "name".
Changes to be committed:
modified: src/interfaces/interfaces.ts
On line 40 the "name.slice()" method was used, which gave an error, so it was removed. Changes to be committed: modified: src/components/studentDetailCards/projectsSection/ProjectsCard.tsx
The data returned by the call to /student/{studentId}/resume/projects, in the end, was correct...
Now it works correctly, I have taken the opportunity to fix a conditional, which rendered the component incorrectly
Changes to be committed:
modified: src/components/studentDetailCards/projectsSection/ProjectsCard.tsx
modified: src/interfaces/interfaces.ts
…e' into 266-4-FE-Refactor
266 4 fe refactor
…tion/ProjectsCard.tsx
tomi-casabona
approved these changes
Oct 10, 2024
…rename-and-reorganise-files-and-folders-structure
…rename-and-reorganise-files-and-folders-structure
StephaneCarteaux
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FE] Refactoring: api folder "src/api"
[FE] Refactoring: "src/store"
[FE] Refactoring: "src/componetnts/"
Before
After