-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#81 fake endpoint that can list collaboration for frontend student detail view #101
Feature/#81 fake endpoint that can list collaboration for frontend student detail view #101
Conversation
routes/api/v1.php
Outdated
@@ -44,6 +45,9 @@ | |||
// Student projects detail Endpoint | |||
Route::get('/students/{id}/projects', StudentProjectsDetailController::class)->name('projects.list'); | |||
|
|||
//Student Collaboration fake Endpoint | |||
Route::get('/studentCollaborations', StudentCollaborationController::class)->name('collaborations.list'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo hubiera separado /student/collaborations, pero es una tontería...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Por mi perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Habría que ver si es necesario incluir el uuid en el controlador y ruta, ya que la colaboración se lista en el detalle particular de cada estudiante. El array puede ser el mismo para todos, ya que el objetivo real es que FE pueda tener esos datos para todos los alumnos, sin importar el contenido.
|
||
class StudentCollaborationController extends Controller | ||
{ | ||
public function __invoke() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Más allá de que son endpoints fake, no deberían corresponder a un uuid? El campo colaboración se desplega en el detalle particular de cada estudiante.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De momento no es necesario Alejandro. Cuando estemos hablando de un endpoint real entonces sí que será necesario pasarle el uuid. Por otro lado se puede añadir el uuid como buena práctica a forma de recordatorio de que éste campo será requerido.
Up to you.
@leidyz haz rebase de los nuevos commits en Develop y comprueba que te pasan todos los tests |
|
||
class StudentCollaborationController extends Controller | ||
{ | ||
public function __invoke() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De momento no es necesario Alejandro. Cuando estemos hablando de un endpoint real entonces sí que será necesario pasarle el uuid. Por otro lado se puede añadir el uuid como buena práctica a forma de recordatorio de que éste campo será requerido.
Up to you.
2461b5c
to
d02a070
Compare
2cc8bda
to
bd0c712
Compare
Add a fake endpoint that can list 'Colaboración' for frontend student detail view with data found in the figma.
all the database info is hardcoded.