add str::substring #158
add str::substring #158
Conversation
|
@ISibboI , the usize overflow was already handled, but I changed the behavior to raise an error instead of returning an empty string when supplied indices are out of bounds. Let me know if that's ok :) |
| assert!(eval("str::substring(\"foobar\", 2, 1)").is_err()); | ||
| assert!(eval("str::substring(\"foobar\", 99999)").is_err()); | ||
| assert!(eval("str::substring(\"foobar\", -1)").is_err()); | ||
| assert!(eval("str::substring(\"foobar\", 0, -1)").is_err()); |
There was a problem hiding this comment.
I think currently, the function accepts also the case where it gets four or more arguments, and silently drops them. Let's add a test case for that, expecting an error. And then if the function does not return an error in that case, let's make it return one.
|
Also, in case I get to implement #159 before merging this, it may be good to use it as well. But I can also do that. |
previously, the function just returned an empty string
|
Yeah, now you can use |
|
Okay, I'm leaving this in your hands. thanks ! |
|
Thank you 🙏 |
No description provided.