Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove COM from DG645 #916

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove COM from DG645 #916

wants to merge 1 commit into from

Conversation

FreddieAkeroyd
Copy link
Member

Description of work

I think COM is incorrect - seen error on EMU

[2025-03-06 10:43:52] INFO -- asynInterposeCOM options extending and perhaps overriding those of lower interface.
[2025-03-06 10:43:52] WARNING -- Can't set serial port parameters: Device says WON'T 0.

To test

Which ticket does this PR fix?

Acceptance criteria

List the acceptance criteria for the PR


Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

Sorry, something went wrong.

@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks Mar 8, 2025
@FreddieAkeroyd FreddieAkeroyd changed the title Remove COM Remove COM from DG645 Mar 8, 2025
@rerpha
Copy link
Contributor

rerpha commented Mar 10, 2025

do we need to test this on a device or have you done so by patching on an instrument?

@FreddieAkeroyd
Copy link
Member Author

FreddieAkeroyd commented Mar 10, 2025

I haven't patched/tested but maybe we can/should, i was going on WARNING -- Can't set serial port parameters: Device says WON'T 0. which suggested it was not doing anything anyway and it was more on teh off chance if it caused any funny issues. So maybe we do it when they the multiple DG645 issue test at end of cycle unless we have a DG645 elsewhere?

@Tom-Willemsen
Copy link
Contributor

will move to a shutdown task as I agree would like to test this on hardware before pressing merge

@Tom-Willemsen Tom-Willemsen moved this from Flash Review to Task in Tasks Mar 13, 2025
@esmith1729
Copy link
Contributor

Talk with Steve Cottrell about testing with two DG645s on EMU for this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Task
Development

Successfully merging this pull request may close these issues.

None yet

4 participants