Changed: enhanced ApiRepository error messages

jest.config.functional.ts

@@ -0,0 +1,6 @@
+import config from './jest.config'
+
+config.modulePathIgnorePatterns = ['<rootDir>/test/unit', '<rootDir>/test/integration']
+console.log('RUNNING FUNCTIONAL TESTS')
+
+export default config

jest.config.integration.ts

@@ -1,6 +1,6 @@
 import config from './jest.config'
 
-config.modulePathIgnorePatterns = ['<rootDir>/test/unit']
+config.modulePathIgnorePatterns = ['<rootDir>/test/unit', '<rootDir>/test/functional']
 console.log('RUNNING INTEGRATION TESTS')
 
 export default config

jest.config.unit.ts

@@ -1,6 +1,6 @@
 import config from './jest.config'
 
-config.modulePathIgnorePatterns = ['<rootDir>/test/integration']
+config.modulePathIgnorePatterns = ['<rootDir>/test/integration', '<rootDir>/test/functional']
 delete config.globalSetup
 delete config.testTimeout
 console.log('RUNNING UNIT TESTS')

package.json

@@ -12,6 +12,7 @@
     "test": "jest -c jest.config.ts",
     "test:unit": "jest -c jest.config.unit.ts",
     "test:integration": "jest -c jest.config.integration.ts",
+    "test:functional": "jest -c jest.config.functional.ts",
     "test:coverage": "jest --coverage -c jest.config.ts",
     "test:coverage:check": "jest --coverage --ci --config jest.config.ts",
     "lint": "npm run lint:eslint && npm run lint:prettier",

src/core/infra/repositories/ApiRepository.ts

@@ -13,11 +13,7 @@ export abstract class ApiRepository {
       .get(this.buildRequestUrl(apiEndpoint), this.buildRequestConfig(authRequired, queryParams))
       .then((response) => response)
       .catch((error) => {
-        throw new ReadError(
-          `[${error.response.status}]${
-            error.response.data ? ` ${error.response.data.message}` : ''
-          }`
-        )
+        throw new ReadError(this.buildErrorMessage(error))
       })
   }
 
@@ -34,11 +30,7 @@ export abstract class ApiRepository {
       )
       .then((response) => response)
       .catch((error) => {
-        throw new WriteError(
-          `[${error.response.status}]${
-            error.response.data ? ` ${error.response.data.message}` : ''
-          }`
-        )
+        throw new WriteError(this.buildErrorMessage(error))
       })
   }
 
@@ -87,4 +79,12 @@ export abstract class ApiRepository {
   private buildRequestUrl(apiEndpoint: string): string {
     return `${ApiConfig.dataverseApiUrl}${apiEndpoint}`
   }
+
+  // eslint-disable-next-line  @typescript-eslint/no-explicit-any
+  private buildErrorMessage(error: any): string {
+    const status =
+      error.response && error.response.status ? error.response.status : 'unknown error status'
+    const message = error.response && error.response.data ? ` ${error.response.data.message}` : ''
+    return `[${status}]${message}`
+  }
 }

test/functional/datasets/CreateDataset.test.ts

@@ -0,0 +1,5 @@
+//import { createDataset, CreatedDatasetIdentifiers } from '../../../src/datasets'
+
+describe('execute', () => {
+  test('should create new dataset', async () => {})
+})

tsconfig.json

@@ -19,7 +19,8 @@
     "test",
     "jest.config.integration.ts",
     "jest.config.js",
-    "jest.config.unit.ts"
+    "jest.config.unit.ts",
+    "jest.config.functional.ts"
   ],
   "exclude": ["node_modules", "dist"]
 }