Merge pull request #355 from IPDSnelting/abs-instr

Format and signify mathlib instructions count by absolute value
IPDSnelting · Oct 11, 2023 · 54874bc · 54874bc
2 parents a27c410 + f1b54be
commit 54874bc
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 4 deletions.
diff --git a/backend/backend/pom.xml b/backend/backend/pom.xml
@@ -172,6 +172,8 @@
         </executions>
         <configuration>
           <dotGitDirectory>${project.basedir}/../../.git</dotGitDirectory>
+          <failOnUnableToExtractRepoInfo>false</failOnUnableToExtractRepoInfo>
+          <failOnNoGitDirectory>false</failOnNoGitDirectory>
           <generateGitPropertiesFile>true</generateGitPropertiesFile>
           <generateGitPropertiesFilename>${project.build.outputDirectory}/git.properties
           </generateGitPropertiesFilename>

diff --git a/...kend/src/main/java/de/aaaaaaah/velcom/backend/data/significance/SignificanceDetector.java b/...kend/src/main/java/de/aaaaaaah/velcom/backend/data/significance/SignificanceDetector.java
@@ -68,6 +68,10 @@ public Optional<SignificanceReasons> getSignificance(Run run, Collection<Run> co
 	}
 
 	private boolean isSignificantDifference(DimensionDifference diff) {
+		if (diff.getDimension().getBenchmark().startsWith("~"))
+			// 1B instructions
+			return diff.getDiff() >= 1_000_000_000;
+
 		boolean relSignificant = diff.getReldiff()
 			.map(reldiff -> Math.abs(reldiff) >= significanceFactors.getRelativeThreshold())
 			// There is no reldiff if the first value is 0. But if the second value is also zero, that

diff --git a/backend/runner/pom.xml b/backend/runner/pom.xml
@@ -66,6 +66,8 @@
         </executions>
         <configuration>
           <dotGitDirectory>${project.basedir}/../../.git</dotGitDirectory>
+          <failOnUnableToExtractRepoInfo>false</failOnUnableToExtractRepoInfo>
+          <failOnNoGitDirectory>false</failOnNoGitDirectory>
           <generateGitPropertiesFile>true</generateGitPropertiesFile>
           <generateGitPropertiesFilename>${project.build.outputDirectory}/git.properties
           </generateGitPropertiesFilename>

diff --git a/frontend/src/components/comparison/RunComparisonTable.vue b/frontend/src/components/comparison/RunComparisonTable.vue
@@ -65,7 +65,7 @@ import { Prop } from 'vue-property-decorator'
 
 const numberFormat: Intl.NumberFormat = new Intl.NumberFormat(
   new Intl.NumberFormat().resolvedOptions().locale,
-  { maximumFractionDigits: 3 }
+  { maximumFractionDigits: 3, notation: 'compact' }
 )
 
 class TableItem {

diff --git a/frontend/src/components/rundetail/MeasurementsDisplay.vue b/frontend/src/components/rundetail/MeasurementsDisplay.vue
@@ -85,7 +85,7 @@ import { vxm } from '@/store'
 
 const numberFormat: Intl.NumberFormat = new Intl.NumberFormat(
   new Intl.NumberFormat().resolvedOptions().locale,
-  { maximumFractionDigits: 3 }
+  { maximumFractionDigits: 3, notation: 'compact' }
 )
 
 class Item {

diff --git a/frontend/src/components/runs/RunSignificanceChips.vue b/frontend/src/components/runs/RunSignificanceChips.vue
@@ -68,7 +68,7 @@ import { Prop } from 'vue-property-decorator'
 
 const numberFormat: Intl.NumberFormat = new Intl.NumberFormat(
   new Intl.NumberFormat().resolvedOptions().locale,
-  { maximumFractionDigits: 1 }
+  { maximumFractionDigits: 1, notation: 'compact' }
 )
 
 const iconMappings = {
@@ -102,7 +102,7 @@ class RelevantChange {
 
       this.change = change
     } else {
-      this.change = difference.relDiff
+      this.change = difference.relDiff && !this.id.benchmark.startsWith('~')
         ? this.formatPercentage(difference.relDiff)
         : this.formatNumber(difference.absDiff)
     }