Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the stalling dev container #989

Open
wants to merge 4 commits into
base: feature/distributed-demo
Choose a base branch
from

Conversation

atomicgamedeveloper
Copy link
Contributor

Pull Request Template

Title

Fixes the stalling dev container

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Security patch
  • UI/UX improvement

Description

I exchanged the ghcr.io/devcontainers-contrib/features/mkdocs:2 which derives from a currently inactive repo to the corresponding layer from the active fork of it, https://github.com/devcontainers-extra/features?tab=readme-ov-file.

Testing

I successfully have built the dev container. This was infeasible before.

Impact

  • One of the layers is now maintained in a different repository.
  • The other layers may eventually stop working unless the original repository reactivates.

Additional Information

Issue discussing this: devcontainers-contrib/features#623

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have added tests for all the new code and any changes made to
    existing code.
  • I have made corresponding changes to the documentation.

@atomicgamedeveloper atomicgamedeveloper marked this pull request as ready for review October 16, 2024 21:52
@prasadtalasila
Copy link
Contributor

The other layers may eventually stop working unless the original repository reactivates.

@atomicgamedeveloper what does this mean? I thought the layers are independent!

@prasadtalasila
Copy link
Contributor

Please upgrade the node to v22.x and yarn to the latest version. Please also upgrade the dependencies and layers to their latest versions.

@atomicgamedeveloper
Copy link
Contributor Author

The other layers may eventually stop working unless the original repository reactivates.

@atomicgamedeveloper what does this mean? I thought the layers are independent!

The other feature layers come from the same inactive repository, so they may face similar issues down the line when we rebuild. A simple solution is just to replace all the sources to the active one.

Please upgrade the node to v22.x and yarn to the latest version. Please also upgrade the dependencies and layers to their latest versions.

Will do now.

Copy link

codeclimate bot commented Oct 25, 2024

Code Climate has analyzed commit a94ad40 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants