-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BU - default style name not consistent with other DS #13
Comments
From the Data Specifications Template: From the data specification for buildings:
I think the proposal should be: Change the style name of the layer BU.Building from "BU.Building.default" to "BU.Building.Default" in section 10.2.1, and change the style name of the layer BU.BuildingPart from "BU.Building.default" to "BU.BuildingPart.Default"in section 10.2.2. |
Yes, agreed. |
Meeting 15-12-2021: The changes are fine, but we have to double-check the legislation. |
The relevant part of the legislation, from https://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:02010R1089-20141231#tocId16:
The legislation does not say anything about the names of the styles, as far as I can see. |
The proposed changes have been already included in the validator since they were considered as a typo in the TG. See related issue. |
During the joint MIG/MIG-T meeting held on 31/03-01/04/2022, the proposal was endorsed. |
Change proposal description
Change the style name of the layer BU.Building from "BU.Building.default" to "BU.Building.Default" in section10.2.1 and 10.2.2
This is the pattern for other styles in INSPIRE and is also already in use in the validator (see this issue and this list of styles checked in the validator.
Addressed TG
D2.8.III.2 Data Specification on Buildings – Technical Guidelines
Location
Section 10.2.1 and 10.2.2
Issue faced
The style name contains "default" with a lowercase "d" which is different from other default styles using an uppercase "D" and different from what the validator expects.
Proposed solution
Replace "BU.Building.default" with "BU.Building.Default"
Pull request
Additional information
Kind of issue
editorial
Impact on INSPIRE validator
The validator will be changed to support both versions - once the change is realised in the DS, the support of the lowercase variant can be removed from the validator.
Linked issue
INSPIRE-MIF/helpdesk-validator#626 (comment)
Change proposer
Johanna Ott
wetransform GmbH
The text was updated successfully, but these errors were encountered: