Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BU - default style name not consistent with other DS #13

Closed
JohannaOtt opened this issue Oct 6, 2021 · 6 comments · Fixed by #166
Closed

BU - default style name not consistent with other DS #13

JohannaOtt opened this issue Oct 6, 2021 · 6 comments · Fixed by #166
Labels
endorsed The change proposal is endorsed by the MIG. impact on validator The change proposal has an impact on the INSPIRE validator.
Milestone

Comments

@JohannaOtt
Copy link

Change proposal description

Change the style name of the layer BU.Building from "BU.Building.default" to "BU.Building.Default" in section10.2.1 and 10.2.2
This is the pattern for other styles in INSPIRE and is also already in use in the validator (see this issue and this list of styles checked in the validator.

Addressed TG

D2.8.III.2 Data Specification on Buildings – Technical Guidelines

Location

Section 10.2.1 and 10.2.2

Issue faced

The style name contains "default" with a lowercase "d" which is different from other default styles using an uppercase "D" and different from what the validator expects.

Proposed solution

Replace "BU.Building.default" with "BU.Building.Default"

Pull request

Additional information

Kind of issue

editorial

Impact on INSPIRE validator

The validator will be changed to support both versions - once the change is realised in the DS, the support of the lowercase variant can be removed from the validator.

Linked issue

INSPIRE-MIF/helpdesk-validator#626 (comment)

Change proposer

Johanna Ott
wetransform GmbH

@heidivanparys heidivanparys added the impact on validator The change proposal has an impact on the INSPIRE validator. label Oct 29, 2021
@heidivanparys
Copy link
Collaborator

From the Data Specifications Template:

image

From the data specification for buildings:

image

image

@JohannaOtt

Change the style name of the layer BU.Building from "BU.Building.default" to "BU.Building.Default" in section10.2.1 and 10.2.2

I think the proposal should be:

Change the style name of the layer BU.Building from "BU.Building.default" to "BU.Building.Default" in section 10.2.1, and change the style name of the layer BU.BuildingPart from "BU.Building.default" to "BU.BuildingPart.Default"in section 10.2.2.

@JohannaOtt
Copy link
Author

JohannaOtt commented Dec 13, 2021

I think the proposal should be:

Change the style name of the layer BU.Building from "BU.Building.default" to "BU.Building.Default" in section 10.2.1, and change the style name of the layer BU.BuildingPart from "BU.Building.default" to "BU.BuildingPart.Default"in section 10.2.2.

Yes, agreed.

@heidivanparys
Copy link
Collaborator

Meeting 15-12-2021: The changes are fine, but we have to double-check the legislation.

@heidivanparys heidivanparys added the for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. label Dec 15, 2021
@heidivanparys
Copy link
Collaborator

The relevant part of the legislation, from https://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:02010R1089-20141231#tocId16:

Article 14

Portrayal

  1. For the portrayal of spatial data sets using a view network service as specified in Commission Regulation No 976/2009 ( 5 ), the following shall be available:

    (a) the layers specified in Annex II for the theme or themes the data set is related to;
    (b) for each layer at least a default portrayal style, with as a minimum an associated title and a unique identifier.

The legislation does not say anything about the names of the styles, as far as I can see.

@fabiovinci
Copy link
Collaborator

The proposed changes have been already included in the validator since they were considered as a typo in the TG. See related issue.

@sMorrone
Copy link
Collaborator

sMorrone commented Apr 4, 2022

During the joint MIG/MIG-T meeting held on 31/03-01/04/2022, the proposal was endorsed.
More details in the meeting minutes on the 69th MIG-T meeting page

@sMorrone sMorrone added endorsed The change proposal is endorsed by the MIG. and removed for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. labels Apr 4, 2022
@fabiovinci fabiovinci added this to the 2024.1 milestone Dec 1, 2023
@fabiovinci fabiovinci linked a pull request Jan 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endorsed The change proposal is endorsed by the MIG. impact on validator The change proposal has an impact on the INSPIRE validator.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants