Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at42-getcapabilities-layer-default-style: wrong default style and missing style for BU #512

Closed
JPPauly opened this issue Feb 19, 2021 · 7 comments
Labels
deployed in reference validator Solution deployed in production requires change in TG The solution of the issue requires a change in TG
Milestone

Comments

@JPPauly
Copy link

JPPauly commented Feb 19, 2021

The ETS for default style name for Bulding (BU) contains 'BU.Building': ['BU.Building.default'], with a lower d default instead of the usual Default, also the second required style of the theme BU.BuildingPart.Default is not contained in the test at all.

This leads to correct wms services wrongly throwing an error in this test.

@JPPauly JPPauly changed the title at42 wrong default style and missing style for BU at42-getcapabilities-layer-default-style: wrong default style and missing style for BU Feb 19, 2021
@carlospzurita
Copy link
Contributor

Dear @JPPauly

Thank you for opening this issue. We checked the ETS and it indeed was checking the wrong value of the default style and we are modifiying it. For the second required style, we have an open issue right now #491 that is also relevant for this issue, and we are working on it. The fix for that issue will reflect the fix in this one.

Kind regards.

@carlospzurita
Copy link
Contributor

Dear @JPPauly

We are changing the ETS for BU to check for BU.Building.Default style.

@fabiovin
Copy link
Collaborator

Dear @carlospzurita,

the check for the BU.BuildingPart.Default style should also be present because BU.BuildingPart is an official layer (It is present on the registry: https://inspire.ec.europa.eu/layer/BU.BuildingPart).

Probably the error is due to a typo in the TG because in the section "10.2.2 Styles for the layer BU.BuildingPart" the "Style Name" is BU.Building.default instead of BU.BuildingPart.Default.

Could you please add it to the ETS?

Thanks,
Fabio

@carlospzurita
Copy link
Contributor

Dear @fabiovin

We are adding this fix on the staging instance.

@carlospzurita
Copy link
Contributor

Dear @JPPauly

We have published a fix for this issue on the staging instance. Could you please check it out and give us some feedback?

Thank you

@carlospzurita carlospzurita added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Mar 11, 2021
@JPPauly
Copy link
Author

JPPauly commented Mar 11, 2021

Dear @carlospzurita

Everything looks good to me and our BU-WMS does not show an error anymore for test at42 in the staging instance.

Thank you.

@carlospzurita carlospzurita added solved Solution developed and accepted, not yet deployed and removed ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing labels Mar 15, 2021
@carlospzurita carlospzurita added deployed in reference validator Solution deployed in production and removed solved Solution developed and accepted, not yet deployed labels Mar 22, 2021
@fabiovinci fabiovinci added the requires change in TG The solution of the issue requires a change in TG label Feb 18, 2022
@fabiovinci
Copy link
Collaborator

The related change proposal for the TG is here.

@fabiovinci fabiovinci added this to the v2021.2 milestone Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed in reference validator Solution deployed in production requires change in TG The solution of the issue requires a change in TG
Projects
None yet
Development

No branches or pull requests

4 participants