[Fix] remove .join in plot_ue function #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wit release of matplotlib 3.8.0 the join method for sharing axis was removed.
This PR fixes the shared y-axes in the
plot_uefunction, by following the recommendation to useAxes.sharey()instead.This change was also implemented in the corresponding UE tutorial in Elephant, see: NeuralEnsemble/elephant#596
See: https://matplotlib.org/3.8.0/api/prev_api_changes/api_changes_3.8.0.html#removals
Modifications to the Groupers returned by get_shared_x_axes and get_shared_y_axes are no longer allowed. Note that previously, calling e.g. join() would already fail to set up the correct structures for sharing axes; use Axes.sharex or Axes.sharey instead.