Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce envrionment.yml dependencies #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

terhorstd
Copy link

The definition of specific builds in the dependencies is dangerous and leads to problems when packages move on. The environment file should only contain top level dependencies that are explicitly required. These dependencies may pull in deeper ones if they need, but it's not for this env to define which that should be. Also the dependencies should only specify to the actual requirements, i.e. probably it is not necessary to have Python "3.7.3=h0371630_0" but any "3.7" would work, maybe even any "3".
This is aimed to fix #3 but I don't have a Mac and can't try. Maybe @jakobj could also have a look if there is more unnecessary dependencies to cut.

@bhargavCSSE
Copy link

Thanks for reviewing the issue. I managed to set it up on ubuntu with no problem. However, I do agree with you on your point that the environment file should only contain top level dependencies that are explicitly required.

@bhargavCSSE
Copy link

Excellent work on building this tool btw 👍

@terhorstd
Copy link
Author

@bhargavCSSE, you could try to remove the gcc-ng dependency on Mac to see if it's really needed. If not, then it should not be in the dependencies. The most clean way would actually be to start with a clean/minimalistic environment.yml and just add lines from the current one if something doesn't work. I would do that, but as mentioned don't have access to a Mac.
If you can get it to run with minimalistic environment, I'd be interested to add your experience to this PR and merge it soon, so you can work with master again.

@terhorstd
Copy link
Author

Excellent work on building this tool btw +1

That goes to @jakobj and @weidel-p
😉

@bhargavCSSE
Copy link

I believe libgcc-ng is needed to compile MPI libraries. Let me work on it and see how it goes. Thanks :)

Copy link

@bhargavCSSE bhargavCSSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still does not work with macOS. No matter though. Its better to work with NEST on ubuntu :). BTW, the new environment file looks much better even for ubuntu platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment.yml
2 participants