-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added local hazard visualization #147
Conversation
Just curious, is tornado (shapefile) not possible yet? |
Tornado is not included in here since it is a shapefile. So just use the local shapefile dataset visualization and it should work |
For consistency of the API maybe it is worthwhile to add a similar method even though it's just wrap around the visualize local dataset? |
I am not very sure if it is worthwhile because it might
We've been started using gdf.explore() for the shapefile visualization and it can't be wrapped. So maybe we can just add an example of showing tornado using gdf.explore() instead of creating the method, like we did in workshop session 2. |
I can create a wrapper for using our existing ones but that wouldn't be any better than using gdf.explore() |
Anyway, I added the local visualization of tornado using the existing method of pyincore-viz. I also updated the description part to include the local tornado visualization. However, still, using gdf.explore() will be better way. |
Code looks good. You might want to include tornado example in the data.zip for easy testing. |
Updated data.zip |
demand_units = eq_dataset.demand_units | ||
hazard_type = eq_dataset.hazard_type | ||
period = eq_dataset.period | ||
title = "Demand Type: " + demand_type.upper() + ", Demand Units: " + demand_units + ", Period: " + \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an aesthetic suggestion, not necessary... but we can use .title() instead of .upper() for the title so the resulting title is not all in uppercase?
Code looks good and testing worked. Just left a small comment about aesthetic but not important |
Added local hazard visualization for earthquake, flood, hurricane, and tsunami. To test this, install the PR branch first, then create a test notebook file using the following code and run the notebook with attached zip file after unzip it.
data.zip