-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #325 - Earthquake hazard visualization bounding box #326
Fixes #325 - Earthquake hazard visualization bounding box #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I thought I tested it and worked okay but the pod had an error. Let me check and test one more time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous test was not done in the correct situation. Let me test one more time after fixing the dev instance
@navarroc These are two outputs from this PR and the existing one that I got from running create_earthquake notebook
Second one
As you can see, those outputs are identical. Maybe I did it wrong but do you have any idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked well. Approve
A bug was introduced by using the reference envelope, which expects x1, x2, y1, y2 whereas the previous expected x1, y1, width, height. This looks to fix the issue, but please check if this is correct.