Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #325 - Earthquake hazard visualization bounding box #326

Conversation

navarroc
Copy link
Member

A bug was introduced by using the reference envelope, which expects x1, x2, y1, y2 whereas the previous expected x1, y1, width, height. This looks to fix the issue, but please check if this is correct.

@navarroc navarroc linked an issue Oct 28, 2024 that may be closed by this pull request
@navarroc navarroc requested review from longshuicy, Rashmil-1999 and ylyangtw and removed request for Rashmil-1999 and ylyangtw October 28, 2024 20:47
Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I thought I tested it and worked okay but the pod had an error. Let me check and test one more time.

Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous test was not done in the correct situation. Let me test one more time after fixing the dev instance

@ywkim312
Copy link
Member

@navarroc These are two outputs from this PR and the existing one that I got from running create_earthquake notebook
First one

from this PR
[{'hazardValues': [0.5322993805448739], 'demands': ['0.2 SA'], 'units': ['g'], 'loc': '35.07899, -90.0178'}, {'hazardValues': [0.502009539659276], 'demands': ['0.2 SA'], 'units': ['g'], 'loc': '35.027, -90.077'}]

from existing one
[{'hazardValues': [0.5322993805448739], 'demands': ['0.2 SA'], 'units': ['g'], 'loc': '35.07899, -90.0178'}, {'hazardValues': [0.502009539659276], 'demands': ['0.2 SA'], 'units': ['g'], 'loc': '35.027, -90.077'}]

Second one

from this PR
[{'hazardValues': [0.3779999911785126], 'demands': ['PGA'], 'units': ['g'], 'loc': '35.1322, -89.9087'}, {'hazardValues': [0.37400001287460327], 'demands': ['PGA'], 'units': ['g'], 'loc': '35.1707, -89.8417'}]

from existing one
[{'hazardValues': [0.3779999911785126], 'demands': ['PGA'], 'units': ['g'], 'loc': '35.1322, -89.9087'}, {'hazardValues': [0.37400001287460327], 'demands': ['PGA'], 'units': ['g'], 'loc': '35.1707, -89.8417'}]

As you can see, those outputs are identical. Maybe I did it wrong but do you have any idea?

Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked well. Approve

@ywkim312 ywkim312 merged commit 76e77fe into develop Oct 31, 2024
7 checks passed
@ywkim312 ywkim312 deleted the 325-earthquake-hazard-visualization-has-incorrect-bounding-box branch October 31, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Earthquake hazard visualization has incorrect bounding box
3 participants