-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.32.1 #198
Release 1.32.1 #198
Conversation
Main to dev
Main to dev
@@ -485,6 +485,18 @@ datawolf: | |||
postgresqlPassword: datawolf | |||
postgresqlDatabase: database | |||
|
|||
extraEnvVars: | |||
- name: DATASET_DAO | |||
value: "edu.illinois.ncsa.incore.dao.IncoreDatasetDao" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause any problem for prod? For the community apps, we don't want to set the dataset day to the Incore one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't matter since this is only for the extra env vars. As long as we don't update the datawolf container image, it shouldn't affect it. It will just simply be an extra environment variable that is not being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navarroc Can you approve this?
@@ -203,7 +203,7 @@ doc_pyincore_viz: | |||
replicas: 1 | |||
image: | |||
repository: doc/pyincore-viz | |||
tag: 1.11.0 | |||
tag: v1.11.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, unfortunately. There is an error in github action so all of them (pyincore, viz, data) can't produce the tag without v. But v tagged one is being produced when the release gets created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made PR for fix this one for pyincore-viz. If it get fixed, will do the same for pyincore, and data
Release 1.32.1 for IN-CORE release 5.5.1