Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.32.1 #198

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Release 1.32.1 #198

merged 8 commits into from
Nov 4, 2024

Conversation

ywkim312
Copy link
Member

@ywkim312 ywkim312 commented Nov 4, 2024

Release 1.32.1 for IN-CORE release 5.5.1

@ywkim312 ywkim312 linked an issue Nov 4, 2024 that may be closed by this pull request
@@ -485,6 +485,18 @@ datawolf:
postgresqlPassword: datawolf
postgresqlDatabase: database

extraEnvVars:
- name: DATASET_DAO
value: "edu.illinois.ncsa.incore.dao.IncoreDatasetDao"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause any problem for prod? For the community apps, we don't want to set the dataset day to the Incore one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't matter since this is only for the extra env vars. As long as we don't update the datawolf container image, it shouldn't affect it. It will just simply be an extra environment variable that is not being used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navarroc Can you approve this?

@@ -203,7 +203,7 @@ doc_pyincore_viz:
replicas: 1
image:
repository: doc/pyincore-viz
tag: 1.11.0
tag: v1.11.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, unfortunately. There is an error in github action so all of them (pyincore, viz, data) can't produce the tag without v. But v tagged one is being produced when the release gets created

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made PR for fix this one for pyincore-viz. If it get fixed, will do the same for pyincore, and data

@ywkim312 ywkim312 merged commit 00cd9f3 into main Nov 4, 2024
1 check passed
@ywkim312 ywkim312 deleted the release-1.32.1 branch November 4, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.32.1
4 participants