-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chacha20 crypto #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 99.89% 99.90%
=======================================
Files 61 62 +1
Lines 949 1031 +82
Branches 196 201 +5
=======================================
+ Hits 948 1030 +82
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Igor-Misic
force-pushed
the
pr-chacha20
branch
2 times, most recently
from
March 28, 2024 19:05
5d863d3
to
2511c4d
Compare
jciberlin
reviewed
Mar 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I have added some comments.
Igor-Misic
force-pushed
the
pr-chacha20
branch
2 times, most recently
from
March 30, 2024 13:05
2704160
to
fdf4a49
Compare
jciberlin
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ChaCha20 cryptography algorithm
ChaCha20 definition document : https://datatracker.ietf.org/doc/html/rfc8439
Checklist
make cppcheck
on my code and fixed any reported issues.make astyle
on my code and ensured that it adheres to the project's formatting guidelines.Additional Notes
In this iteration, the primary objective was to achieve MISRA compliance. Depending on the level of interest in this implementation, we can explore the possibility of selectively omitting certain MISRA rules in exchange for improved performance.