Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chacha20 crypto #72

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Add chacha20 crypto #72

merged 1 commit into from
Mar 30, 2024

Conversation

Igor-Misic
Copy link
Member

@Igor-Misic Igor-Misic commented Mar 28, 2024

Description

Add ChaCha20 cryptography algorithm
ChaCha20 definition document : https://datatracker.ietf.org/doc/html/rfc8439

Checklist

  • I have read and understood the contribution guidelines.
  • I have added any necessary documentation (if appropriate).
  • I have added unit tests (if appropriate).
  • I have run make cppcheck on my code and fixed any reported issues.
  • I have run make astyle on my code and ensured that it adheres to the project's formatting guidelines.
  • Test coverage is at 100% for the modified code.

Additional Notes

In this iteration, the primary objective was to achieve MISRA compliance. Depending on the level of interest in this implementation, we can explore the possibility of selectively omitting certain MISRA rules in exchange for improved performance.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (b8a1468) to head (9a4eca6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   99.89%   99.90%           
=======================================
  Files          61       62    +1     
  Lines         949     1031   +82     
  Branches      196      201    +5     
=======================================
+ Hits          948     1030   +82     
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Igor-Misic Igor-Misic force-pushed the pr-chacha20 branch 2 times, most recently from 5d863d3 to 2511c4d Compare March 28, 2024 19:05
@Igor-Misic Igor-Misic requested a review from jciberlin March 28, 2024 19:31
Copy link
Member

@jciberlin jciberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have added some comments.

Inc/crypto/chacha20.h Outdated Show resolved Hide resolved
Inc/crypto/chacha20.h Outdated Show resolved Hide resolved
Inc/crypto/chacha20.h Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Src/bit_manipulation.c Show resolved Hide resolved
Src/crypto/chacha20.c Show resolved Hide resolved
Src/crypto/chacha20.c Outdated Show resolved Hide resolved
Src/crypto/chacha20.c Show resolved Hide resolved
Src/crypto/chacha20.c Show resolved Hide resolved
Tests/test_chacha20.c Outdated Show resolved Hide resolved
@Igor-Misic Igor-Misic force-pushed the pr-chacha20 branch 2 times, most recently from 2704160 to fdf4a49 Compare March 30, 2024 13:05
@Igor-Misic Igor-Misic requested a review from jciberlin March 30, 2024 13:37
@jciberlin jciberlin merged commit ad4a4f5 into main Mar 30, 2024
9 checks passed
@jciberlin jciberlin deleted the pr-chacha20 branch March 30, 2024 17:24
@Igor-Misic Igor-Misic added the enhancement New feature or request label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants