Maintainer group is made optional for accessing maintainer site #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algomaster99
requested changes
Oct 8, 2020
src/actions/apiInfoCall.js
Outdated
| dispatch(receiveProjectData(projectUrl, projectRes)) | ||
| }) | ||
| .catch(error => { | ||
| console.log(error) |
src/components/app.js
Outdated
| apiInfoData.projectLoaded | ||
| ) { | ||
| return ( | ||
| <div styleName="blocks.container"> | ||
| <AppHeader | ||
| handleClick={this.handleShow} | ||
| onClick={this.handleHide} | ||
| title={apiInfoData.footerData.name} | ||
| title={apiInfoData.footerData?apiInfoData.footerData.name:null} |
There was a problem hiding this comment.
apiInfoData.footerData && apiInfoData.footerData.name
No need to use ternary operator
src/components/footer/app-footer.js
Outdated
| @@ -44,7 +44,7 @@ class FooterSection extends Component { | |||
| return ( | |||
| <footer styleName="styles.container" onClick={this.handleClickCounter}> | |||
| <Container>{`© ${date.getFullYear()} ${ | |||
| this.props.info.name | |||
| this.props.info?this.props.info.name:'-' | |||
There was a problem hiding this comment.
Add space like this:
this.props.info ? this.props.info.name : '-'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in Progress. Need a PR for social, contact etc. information to work properly.