Handle errors when serializing logged objects in console plugin

[ewoerner]

When serialization of a value for console output using JSON.stringify() fails for any reason, use its toString() implementation as a fallback instead of throwing.

Closes #759

[github-actions]

🤖 Pull request artifacts

file	commit
IITC_Mobile-test.apk	3c0adac
test-0.38.1.20240917.191202.zip	3c0adac

See build on website

[modos189]

I observe that typing console.log(window) without and with a fix causes the browser to freeze.

After fixing in Chrome, after waiting for some time, the output is displayed correctly.
In Firefox in both cases the exception “Uncaught InternalError: too much recursion” occurs and the output is incorrect.

[xscreach]

I observe that typing console.log(window) without and with a fix causes the browser to freeze.

After fixing in Chrome, after waiting for some time, the output is displayed correctly.
In Firefox in both cases the exception “Uncaught InternalError: too much recursion” occurs and the output is incorrect.

That's what i thought... the code is missing a catch... will comment where...

[xscreach]

There/here also needs to be a catch, otherwise the error thrown will continue until browser handles it.
The catch should also return something for the output...
Maybe smth like

} catch (e) {
  return "error rendering: " + String.valueOf(value);
}

... the idea is to output the message and string representation of that object which should output some nonsense like [[Object object]] - which is still less confusing that either error or empty/undefined value

[le-jeu]

indeed, but more likely v = "error rendering: " + String.valueOf(v); just in case the dev used console.log(window, 42)