Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IITC-Mobile: Mobile pane API #503

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

le-jeu
Copy link
Contributor

@le-jeu le-jeu commented May 11, 2021

following #220 idea

I'm going to replace this with more simple and straightforward API, involving single call.
Like this:

addMobilePane(id,title,icon,onFocus)

where onFocus is function that should return html element to show.

That's all. No need to handle anything. No need in special css (in most cases).

@johnd0e
Copy link
Contributor

johnd0e commented May 12, 2021

Currently 'icon' is just mobile resource identifier, which could be enough for standard plugins, but very limiting for any 3rd-party ones.

I wonder if it possible to use icons not embedded into app.

@modos189
Copy link
Contributor

Currently 'icon' is just mobile resource identifier, which could be enough for standard plugins, but very limiting for any 3rd-party ones.

I wonder if it possible to use icons not embedded into app.

I don't know how hard it is for us to implement, but yes, we can pass the icon from the plugin as a blob. However, there will inevitably be problems with this in the future:

  • Such icons will not be optimized for different screen sizes
  • plugin developers are rarely designers, and therefore will tend to use icons that are out of style
  • such icons will not support a dark/light theme.

For this reason I propose to use only Material icons.

@johnd0e
Copy link
Contributor

johnd0e commented May 14, 2021

  • Such icons will not be optimized for different screen sizes

SVG

  • plugin developers are rarely designers, and therefore will tend to use icons that are out of style

Then we will blame them

For this reason I propose to use only Material icons.

But embedded set of icons is extremely limited.

@modos189
Copy link
Contributor

I think Material icons are enough, but ok, we can consider using svg icons

@johnd0e
Copy link
Contributor

johnd0e commented May 14, 2021

I think Material icons are enough

I could agree with you if it would possible to request any icon just by it's id, and then IITCm download (and cache) it.

@MysticJay

This comment has been minimized.

@johnd0e
Copy link
Contributor

johnd0e commented Dec 17, 2021

conflicts!

@modos189 modos189 self-assigned this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants