Portal History Ornaments #445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnd0e
requested changes
Mar 16, 2021
|
In general: I'm not sure about ornaments. |
MysticJay
force-pushed
the
History-Ornaments
branch
from
b13d4e1
to
2ba2cd7
Compare
MysticJay
changed the title
MysticJay
added
enhancement
MysticJay
added
Ready to merge
and removed
WIP
MysticJay
force-pushed
the
History-Ornaments
branch
2 times, most recently
from
00811ca
to
3c8edbc
Compare
johnd0e
requested changes
Mar 27, 2021
johnd0e
requested changes
Mar 27, 2021
johnd0e
requested changes
Mar 29, 2021
Highlighter & Ornaments for portal history
removed code for the highlighter using own namespace
removing highlighter remnants
SVG-Icons by @EisFrei
comment layer based code.
Exposed Functions var vs let,const unused code removed
Removing unused exposures Removing unused functions & hooks Co-Authored-By: Martin <[email protected]>
style for Button not working properly. Co-Authored-By: Martin <[email protected]>
hide toggle button when layer is inactive Co-Authored-By: Martin <[email protected]>
Co-authored-by: johnd0e <[email protected]>
Various fixes to address reviews.
function getSVGString Co-Authored-By: LeJeu <[email protected]>
adding symbols to body
removed need for CSS SVG-icond not reusable SVG symbols based on FontAwsome Button and dialog now communicate turning of the layer removes the button as well, Co-Authored-By: McBen <[email protected]>
code corrections based on eslint Co-Authored-By: McBen <[email protected]>
hide button on startup. Co-Authored-By: McBen <[email protected]>
based on eslint
- changed names of expoed functions - housekeeping
fixinf eslint complaints
layout and CSS changed.
Disabling this line. Seems not to work in IITCm dialog() caused "undefined" error
MysticJay
force-pushed
the
History-Ornaments
branch
from
ab0796f
to
493b3e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ornaments for portal history
allows to reverse the ornament with a toggle button.
adopts color scheme and logic of "highlight portals by histroy" plugin.
SVG-Implementation and dialog by @EisFrei