Uniques040 #416
Draft
Uniques040 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le-jeu
reviewed
Dec 29, 2020
le-jeu
reviewed
Dec 29, 2020
modos189
reviewed
Jan 20, 2021
johnd0e
requested changes
Feb 15, 2021
johnd0e
requested changes
Feb 15, 2021
MysticJay
commented
Feb 18, 2021
johnd0e
requested changes
Feb 20, 2021
le-jeu
reviewed
Feb 22, 2021
johnd0e
reviewed
Feb 24, 2021
Routines and data cretaed.
Added Highlighters description added new text to comm analysis minor cosmetics
sorting scouted or droned caused an empty list, as old uniques might not have the related fields.
Some combinations should not happen, but they do. fixed too.
Feature complete - renamed export/import to backup/restore - merged the dialogs, - removed the copy paste araea - added missingLatLng List to dialog
Added CSS to remove dialog max width limitation
Removing abandoned dialog (copy/paste im/-export)
less verbosity fixed function call to new syntax
- Import function fixed - improved dialog
changing indentation from tab to 2 spaces caused too many changes- undone
headers aligned
0.3.9 -> 0.4.0
moving code back to using uniques.css
Added "x deployed a Beacon on z" "x deployed Fireworks on z"
duplicate dialog during export removed Co-authored-by: Alexander Danilov <[email protected]>
Names for the highlighters were in conflic with history highlighters.
small fixes as proposed by @johnd0e Co-authored-by: johnd0e <[email protected]>
fixing code style as requested by @johnd0e
code style changes
ode and properties changed:
scouted -> scoutControlled
droned ->droneVisited
converter implemented. It will add a version info to the uniques MAP.
removing !important from CSS
le-jeu
requested changes
Nov 20, 2022
|
@MysticJay Do you intend to continue this contribution? If not, could you close it? |
|
please stop this |
Co-authored-by: LeJeu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends UNIQUES to allow keeping track of portals that have been scanned for "Scout Controller" (scoutControlled) or visited by a "Drone" (dronedVisited).
In general the user has to mark scoutControlled or droneVisited portals manually. Additionally UNIQUES will analyze the COMM on ALL and ALERTS (requires a core change to CHAT.JS) for messages that indicate a previous actions withthe portal. The information will be added immediately to the portal-list to those portals visible on the map. For unresolved portals the information (LatLonE6) will be stored in a separate list called missedPortals. As soon as one of the missed portals appears on the map the information will be added to portal-list as well.
To improve the hitrate, when resolving the information the plugin Cache-Portals-On-Map and Offle can assist to resolve LatLonE6 to guid.
UNIQUES now has a dialog that allows to jump to those locations listed in missedLatLngs. Also it allows to export/backup and iport/restore UNIQUES data to/from a local file.