Update portal counts plugin to integrate with draw tools and uniques #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate with the uniques plugin, if active.
Integrate with draw tools
modos189
requested changes
Jul 12, 2020
Co-authored-by: Alexander Danilov <[email protected]>
Co-authored-by: Alexander Danilov <[email protected]>
Co-authored-by: Alexander Danilov <[email protected]>
Co-authored-by: Alexander Danilov <[email protected]>
Co-authored-by: Alexander Danilov <[email protected]>
Good suggestions! All proposed changes merged. |
modos189
previously approved these changes
Jul 12, 2020
johnd0e
reviewed
Jul 14, 2020
| // Determine if a point is inside of a polygon. | ||
| // ray-casting algorithm based on | ||
| // https://observablehq.com/@tmcw/understanding-point-in-polygon | ||
| window.plugin.portalcounts.portalinpolygon = function(portal,LatLngsObjectsArray) { |
There was a problem hiding this comment.
- Shouldn't we include some pip algorithm in IITC api? It is used in many plugins already.
- I'm going to open separate issue to discuss another opportunity: what if we provide general portal-filtering API?
For example, it'd be possible to use more convenient region selection tools, like these: Idea: region selection utility #27
There was a problem hiding this comment.
It would be great if common functions were included in API. We can replace this code when corresponding API appears
modos189
force-pushed
the
master
branch
3 times, most recently
from
a34b800
to
7b9edd5
Compare
|
@erikchristiansson |
johnd0e
dismissed
modos189’s stale review
intel portal history not supported yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display count of unvisited and uncaptured portals if the uniques plugin is installed.
If any polygons are draw, only count portals in the polygons.