-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Bookmarks with SortableJS #346
base: master
Are you sure you want to change the base?
Conversation
@@ -1,10 +1,13 @@ | |||
// @author ZasoGD | |||
// @author ZasoGD / Aradiv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reserve this field to original author, and do not change unless you rewrite plugin from scratch.
You may want to introduce separate field @coauthor
or @collaborator
or @contributor
, but then we should keep same approach through all plugins, which currently is not in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is a different issue, I added myself to a script internal history (which I still prefer), but it was not excepted either.
As scripts tend to be privately improved, extended or modified in a different ways and get shared outside of GIT and version numbers have their own lives anyway, we need to address this somehow. @johnd0e please create a separate discussion issue on this.
While working on this PR - may be you will be able to find what is root source of #241 |
As I can see SortableJS should support touch. |
a34b800
to
7b9edd5
Compare
This PR is a WIP rewrite of the bookmarks plugin.
There are still some issues open and stuff that needs to be fixed.
Known Bug/ToDo List
ToDo: disallow sorting directory below idOthers