Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bookmarks with SortableJS #346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aradiv
Copy link

@Aradiv Aradiv commented Feb 26, 2020

This PR is a WIP rewrite of the bookmarks plugin.

There are still some issues open and stuff that needs to be fixed.

Known Bug/ToDo List

  • folders can be sorted below idOthers but this will be reverted on the next refresh.
    ToDo: disallow sorting directory below idOthers
  • ToDo: test Mobile
  • ToDo: (optional) check loadStorage() call and remove where they are not neccessary
  • ToDo: a lot more testing

@@ -1,10 +1,13 @@
// @author ZasoGD
// @author ZasoGD / Aradiv
Copy link
Contributor

@johnd0e johnd0e Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reserve this field to original author, and do not change unless you rewrite plugin from scratch.

You may want to introduce separate field @coauthor or @collaborator or @contributor, but then we should keep same approach through all plugins, which currently is not in case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a different issue, I added myself to a script internal history (which I still prefer), but it was not excepted either.
As scripts tend to be privately improved, extended or modified in a different ways and get shared outside of GIT and version numbers have their own lives anyway, we need to address this somehow. @johnd0e please create a separate discussion issue on this.

@johnd0e
Copy link
Contributor

johnd0e commented Feb 28, 2020

While working on this PR - may be you will be able to find what is root source of #241

@johnd0e johnd0e mentioned this pull request Mar 3, 2020
@johnd0e
Copy link
Contributor

johnd0e commented Mar 3, 2020

As I can see SortableJS should support touch.
jQueryUI fails with this (though there are plugins like https://github.com/heyman/jquery-draggable-touch and https://www.npmjs.com/package/touch-dnd).

@johnd0e johnd0e added enhancement New feature or request plugin labels Mar 3, 2020
@modos189 modos189 force-pushed the master branch 3 times, most recently from a34b800 to 7b9edd5 Compare December 12, 2020 07:21
@johnd0e johnd0e mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants