Refactoring and Vuejs #314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modos189
force-pushed
the
master
branch
3 times, most recently
from
a34b800
to
7b9edd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons are described in #200
Simple connection Vue does not break anything, but the point is to rewrite interface on modern tools and create a convenient API to work with it.
Therefore, to support plugins that use old DOM intervention method, we need code that detects changes and translates it to new API.
For now, I just divided interface into base blocks, which I put into separate .vue files. For those who didn't work with Vuejs, these files are a collection of html, js and css for a single block.
I also rewrote the toolbox and created an API to add links to the toolbox (see toolbox.vue file):
vm.toolbox.add_item({id: 'mybtn', value: 'My button'})
To support the old plugins, I wrote a translator that tracks the appearance of new items in a hidden old toolbox and calls the new API (see sidebar.vue).