ITC-Mobile: option to use external browser for Google OAuth #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added an option to select a method for opening external links (classic method, custom tabs, browser) Known issues: * Authorization in Sync plugin using Custom Tabs or a browser is not supported because Google Drive library checks for Google cookies * Custom tabs are not supported until android 5.0. It is necessary to add a version check to prevent crashing
Change setting key type to string
modos189
force-pushed
the
master
branch
3 times, most recently
from
a34b800
to
7b9edd5
Compare
|
do you succeed to log with custom tabs ? I fail to get the redirection back to IITCm Edit: ok, got it working on Intel login, but fails with plugin login (even with the button to get back to iitcm) |
I had the same issue, and was going to forbid external login for sync. |
|
There are possible 2 different approaches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is