Fixes to the tech layer map used by klayout for DEF -> GDS #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smunaut
requested review from
KrzysztofHerman and
sergeiandreyev
as code owners
With the current one, any 'PIN' (EDI) area would only end up as 'pin' (datatype 2) in the GDS. But it also needs to appear in the `drawing` (datatype 0). Signed-off-by: Sylvain Munaut <[email protected]>
Signed-off-by: Sylvain Munaut <[email protected]>
|
Thank you for this PR. I have tested is elaborating |
|
See attached zip Note that to see the difference you need to change the "stipple" for the
|
|
BTW I think the issue is not usually visible in ORFS because the pins created by default are the same width as the traces and might have their anchor point on the edge rather than in the center. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.