Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat(#9): support flags option and add casefold option #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ feat(#9): support flags option and add casefold option #13

wants to merge 1 commit into from

Conversation

IGLOU-EU
Copy link
Owner

@IGLOU-EU IGLOU-EU commented May 8, 2023

There are the modifications:

  • Add a custom type and constant for flags with bitwise
  • Add a flag CASEFOLD for case-insensitive operation
  • Update README feature part
  • Add it to benchmark and update the result into README
  • Update test case to it

I'm not sure about the purpose of this feature, they add a condition, strings.ToLower are slow and result in some memory allocation.

@IGLOU-EU IGLOU-EU added enhancement New feature or request help wanted Extra attention is needed labels May 8, 2023
@IGLOU-EU IGLOU-EU force-pushed the feature/issue-9 branch from 28cc849 to a4c5115 Compare May 8, 2023 14:11
@IGLOU-EU IGLOU-EU force-pushed the feature/issue-9 branch from a4c5115 to a2d90ae Compare May 8, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IGLOU-EU