Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix 2] - Fix issues on dref import and imminent risk map #1467

Draft
wants to merge 3 commits into
base: hotfix/hide-wfp-adam
Choose a base branch
from

Conversation

tnagorra
Copy link
Member

@tnagorra tnagorra commented Nov 13, 2024

Addresses:

  • Imminent risk watch
    • Update labels for severity control
      • Green -> 60 km/h
      • Orange -> 90 km/h
      • Red -> 120 km/h
    • Update how event details is shown
      • Previously, we had a navigation system
      • Now, we have exandable container
  • DREF Import template
    • Fix issue related to richtext and excel
      • Filtered out empty text items
    • Fix issue with injecting client id
      • We were injecting clientId instead of client_id
      • We were not injecting clientId if keyFieldName was defined
    • Update descriptions on the dref import template
      • Add proposed guidance for the questions that cascade
      • Add text field for Major coordination mechanism in place

Changes

  • Update labels for severity control
    • Green -> 60 km/h
    • Orange -> 90 km/h
    • Red -> 120 km/h
  • Update how event details is shown
    • Previously, we had a navigation system
    • Now, we have exandable container
  • Fix issue related to richtext and excel
    • Filtered out empty text items
  • Fix issue with injecting client id
    • We were injecting clientId instead of client_id
    • We were not injecting clientId if keyFieldName was defined
  • Update descriptions on the dref import template

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 5146eca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
go-web-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tnagorra tnagorra marked this pull request as draft November 13, 2024 05:22
@tnagorra tnagorra changed the title Fix issues on dref import and imminent risk map [Hotfix] - Fix issues on dref import and imminent risk map Nov 13, 2024
- Update labels for severity control
    - Green -> 60 km/h
    - Orange -> 90 km/h
    - Red -> 120 km/h
- Update how event details is shown
    - Previously, we had a navigation system
    - Now, we have exandable container
- Fix issue related to richtext and excel
    - Filtered out empty text items
- Fix issue with injecting client id
    - We were injecting clientId instead of client_id
    - We were not injecting clientId if keyFieldName was defined
@tnagorra tnagorra changed the title [Hotfix] - Fix issues on dref import and imminent risk map [Hotfix 2] - Fix issues on dref import and imminent risk map Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants