-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Argo hooks Implementation #2320
base: develop
Are you sure you want to change the base?
Conversation
681f090
to
620f9f7
Compare
9145e66
to
3dac5af
Compare
Add github workflow_dispatch
Let's test this using tc-local talos... then we can merge this |
Hi @szabozoltan69 @Lusengeri, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@susilnem , at the moment, the go-api isn't being managed using argocd. As such, the included argo hooks will not have any effect. I would suggest we try this out on sandbox environment first. Also, using argoCD would mean replacing the current deploy pipeline. We should test this out properly before replacing the current helm-release based deployment. I am available to support this change but we would need to coordinate.
Thanks @Lusengeri for the review! We’re using argo-hooks for all alpha instances internally, which is a good starting point for testing and future ArgoCD integration in the go-api. It’s a good time to review and experiment with it. If you have any quick feedback on the implementation, please share! @szabozoltan69 If you're interested, @susilnem can share a quick preview during the next dev call 😃 |
Addresses
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.