Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Argo hooks Implementation #2320

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add Argo hooks Implementation #2320

wants to merge 3 commits into from

Conversation

susilnem
Copy link
Member

@susilnem susilnem commented Nov 22, 2024

Addresses

Changes

  • Add meta annotation for the celery.
  • Fix config map for ELASTIC_SEARCH_HOST
  • Add post sync argo hooks:
    • migrations
    • Collect static
    • Alpha users

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@susilnem susilnem force-pushed the project/argo-hooks branch 3 times, most recently from 681f090 to 620f9f7 Compare November 29, 2024 10:35
@susilnem susilnem marked this pull request as ready for review November 29, 2024 11:23
Add github workflow_dispatch
@thenav56
Copy link
Member

Let's test this using tc-local talos... then we can merge this

@susilnem
Copy link
Member Author

Hi @szabozoltan69 @Lusengeri,
Could you please review this and merge if everything looks good?
Thanks!

Copy link

@Lusengeri Lusengeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susilnem , at the moment, the go-api isn't being managed using argocd. As such, the included argo hooks will not have any effect. I would suggest we try this out on sandbox environment first. Also, using argoCD would mean replacing the current deploy pipeline. We should test this out properly before replacing the current helm-release based deployment. I am available to support this change but we would need to coordinate.

@thenav56
Copy link
Member

@susilnem , at the moment, the go-api isn't being managed using argocd. As such, the included argo hooks will not have any effect. I would suggest we try this out on sandbox environment first. Also, using argoCD would mean replacing the current deploy pipeline. We should test this out properly before replacing the current helm-release based deployment. I am available to support this change but we would need to coordinate.

Thanks @Lusengeri for the review!

We’re using argo-hooks for all alpha instances internally, which is a good starting point for testing and future ArgoCD integration in the go-api. It’s a good time to review and experiment with it. If you have any quick feedback on the implementation, please share!

@szabozoltan69 If you're interested, @susilnem can share a quick preview during the next dev call 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants