Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending mails #61

Merged
merged 14 commits into from
Jun 14, 2024
Merged

Sending mails #61

merged 14 commits into from
Jun 14, 2024

Conversation

ChiragJS
Copy link
Contributor

@ChiragJS ChiragJS commented Jun 9, 2024

  1. Dont merge this pr for now , not complete, will make further commits
  2. add the credentials in application-dev.properties to test the feature out in dev profile(username and password)
  3. For testing purposes i called the mailing function on the root url for the app, will have to place the function calls on particular functions
  4. Not yet implemented the logic for sending attachments
  5. No need for starttls property in application props , as we are using port 465
  6. Will make the necessary changes in the next Commit on this branch

@ChiragJS
Copy link
Contributor Author

This pr addresses issue #20

@SundarakrishnanN SundarakrishnanN requested review from chrisvrose and SundarakrishnanN and removed request for chrisvrose June 11, 2024 14:06
Copy link
Member

@SundarakrishnanN SundarakrishnanN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now..Maybe for later,we can keep beautification of mail upon user creation.

@Prajwalprakash3722
Copy link
Member

I think you can keep the same template, change the template content

@SundarakrishnanN
Copy link
Member

I think you can keep the same template, change the template content

Yep,will do that before we go for the real launch..but can be merged for now

@SundarakrishnanN SundarakrishnanN merged commit 19b19f8 into master Jun 14, 2024
3 checks passed
@SundarakrishnanN SundarakrishnanN deleted the sendingMails branch June 14, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants